Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indexing filterchecks #1843

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Indexing filterchecks #1843

wants to merge 1 commit into from

Conversation

ldegio
Copy link
Contributor

@ldegio ldegio commented May 6, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

add a new new field, fd.containerpidname, which can be used to get a true unique identifier for a file or a connection

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@poiana
Copy link
Contributor

poiana commented May 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ldegio
Once this PR has been reviewed and has the lgtm label, please assign mstemm for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the size/L label May 6, 2024
@ldegio @leogr
new field: fd.containerpidname, which can be used to get a true uniqu…
3b49127 
…e identifier for a file

Signed-off-by: Loris Degioanni <[email protected]>
@poiana poiana added size/S and removed size/L labels May 7, 2024
@FedeDP
Copy link
Contributor

FedeDP commented May 15, 2024

Thanks for this PR! Since we are targeting 0.17.0 release for next week, i'll put this in the 0.18.0 milestone :)
/milestone 0.18.0

@poiana poiana added this to the 0.18.0 milestone May 15, 2024
@incertum
Copy link
Contributor

incertum commented Aug 8, 2024

Hi @ldegio we are having similar asks for example here #1981 (comment).

I would personally prefer expanding the new planned .join #1925 (or a different name) operator, so that we don't need new fields just for concatenating existing ones. What would be your take on this?

@FedeDP
Copy link
Contributor

FedeDP commented Aug 27, 2024

Moving to 0.19 milestone as we do not have bandwidth for this rn.
/milestone 0.19.0

@poiana poiana modified the milestones: 0.18.0, 0.19.0 Aug 27, 2024
@FedeDP
Copy link
Contributor

FedeDP commented Nov 13, 2024

/milestone 0.20.0

@poiana poiana modified the milestones: 0.19.0, 0.20.0 Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andreagit97 Andreagit97 Awaiting requested review from Andreagit97

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
area/libsinsp dco-signoff: yes kind/feature New feature or request release-note-none size/S
Projects
None yet
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ldegio @poiana @FedeDP @incertum